Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and fix BuildMerklePath #7642

Open
gjermundgaraba opened this issue Dec 9, 2024 · 2 comments
Open

Clean up and fix BuildMerklePath #7642

gjermundgaraba opened this issue Dec 9, 2024 · 2 comments
Labels
feat: ibc-eureka

Comments

@gjermundgaraba
Copy link
Contributor

  • BuildMerklePath should panic on empty prefix (not return like it does now)
  • BuildMerklePath needs to be cleaned up (it ugly!)
  • Move it to 23-commitment and to be a method on MerklePath that clones itself and returns a new one
  • Document it well
@github-project-automation github-project-automation bot moved this to Backlog in IBC-GO Eureka Dec 9, 2024
@lacsomot
Copy link
Contributor

Hi. Is this still needed ?

@DimitrisJim
Copy link
Contributor

this one might be slightly more involved @lacsomot 😬 Maybe best to see if some other good issues pop up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: ibc-eureka
Projects
IBC-GO Eureka
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gjermundgaraba @DimitrisJim @lacsomot