Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same store key for nextSequenceSend in v1 and v2 channels #7684

Open
gjermundgaraba opened this issue Dec 12, 2024 · 0 comments
Open

Same store key for nextSequenceSend in v1 and v2 channels #7684

gjermundgaraba opened this issue Dec 12, 2024 · 0 comments

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Dec 12, 2024

nextSequenceSend should be the same key for v1 and v2 channels.

This means we need to change v1 to use the same key path as v2 and have a store migration for that.

Make sure we have tests that cover this before implementing this change. We want to make sure we don't regress on this.

We should also use the same codepaths for this, so we don't have getting/setting nextSequenceSend and the keys in multiple places (i.e. reuse the upgraded paths from v1)

@gjermundgaraba gjermundgaraba changed the title same store key for nextSequenceSend in v1 and v2 channels Same store key for nextSequenceSend in v1 and v2 channels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant