Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoOp err in v2 timeout not possible #7686

Open
gjermundgaraba opened this issue Dec 12, 2024 · 2 comments
Open

NoOp err in v2 timeout not possible #7686

gjermundgaraba opened this issue Dec 12, 2024 · 2 comments

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Dec 12, 2024

In channel v2 timeout the switch on err is using the err from a previous context because it is done as a if err := (i.e. it will always be nil and the noOp case can never happen).

Also, add tests for noOp scenarios across channel-04 v2 to make sure it works everywhere.

@iIvaki
Copy link
Contributor

iIvaki commented Dec 13, 2024

@gjermundgaraba can I do this?

@gjermundgaraba
Copy link
Contributor Author

Thank you for your interest @iIvaki, but I think the core team will take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants