Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasRole endpoint not working #88

Open
yuanchen233 opened this issue Jun 14, 2024 · 1 comment
Open

HasRole endpoint not working #88

yuanchen233 opened this issue Jun 14, 2024 · 1 comment

Comments

@yuanchen233
Copy link
Collaborator

  1. update the return type to Boolean
  2. user accessing resources outside of scope should not be handled here (no 400 exceptions throw here)
  3. Error handling: 404 if account not found, and also fix error handling for other endpoints in AccountController
@yuanchen233
Copy link
Collaborator Author

This was brought up during http-client-rewrite.
However, where is this endpoint currently used. and how is it expected to work?
If this is something before introducing Claims and no longer used, we should consider removing it.
or, find the correct use case and re-do requirement, since access control is managed by backend using Claims now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant