You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we want to do some more extensive shell guessing by iterating over processes, could we not limit ourselves to the parents of the crc process?
I'd prefer that we extend this approach and drop the calls to an external command, and the parsing which comes with it.
In the scenario described above on macos, with pstree I get this so I can find the right terminal without relying on "latest launched"
(I'm not suggesting to use pstree directly, but to do something similar in go)
Acceptance Criteria
Investigate whether shell can be detected correctly using parent process approach programmatically without using any command
If investigation is successful , refactor current shell detection mechanism to be based on this approach.
The text was updated successfully, but these errors were encountered:
getNameAndItsPpid may not have the behaviour we want now, but can it be fixed to do what we need? Imo, this is what we want to do, start from the current process, and look at the process names/command lines until one is a shell process.
rohanKanojia
changed the title
Refactor CRC shell detection mechanism to use process parent programattically
Refactor CRC shell detection mechanism to use process parent programatically
Jan 9, 2025
Description
Originally posted by @cfergeau in #4526 (comment)
Acceptance Criteria
The text was updated successfully, but these errors were encountered: