Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overall better sampling #20

Open
cserteGT3 opened this issue May 13, 2020 · 2 comments
Open

Overall better sampling #20

cserteGT3 opened this issue May 13, 2020 · 2 comments

Comments

@cserteGT3
Copy link
Owner

cserteGT3 commented May 13, 2020 •
edited
Loading

Sampling is currently requires time and ugly. I should completely rethink it.

  • should be move to a function, in theory it could be computed from a PointCloud and the parameters.
@cserteGT3 cserteGT3 mentioned this issue May 13, 2020
Open
7 tasks
@cserteGT3
Copy link
Owner Author

cserteGT3 commented May 22, 2020 •
edited
Loading

A couple of sampling functions are implemented in 29c70a1.
The best time is given by the 4th, but it allocates a lot. Comparing on master with the commit before gaves a bit of speed advancement, but allocates more. Not sure of the speed is noise or not.
From julia 1.5 views don't allocate, which give better results for both (the "original" and the 4th sampling) functions.
RANSACBenchmark.jl now has a couple functions that help to benchmark sampling functions.

@cserteGT3
Copy link
Owner Author

#24 is merged, so from now on it's easier to play with sampling. Though I still need to check the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cserteGT3