Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Enum instance #14

Open
brussee opened this issue Jan 28, 2018 · 0 comments
Open

Enum instance #14

brussee opened this issue Jan 28, 2018 · 0 comments

Comments

@brussee
Copy link

brussee commented Jan 28, 2018

An Enum should not represent a choice itself.

public function getChoice() {

$this->order[] = $column . ' ' . $direction->getChoice();

In the usage example above, I think, it is better to create an OrderDirectionsEnum (plural) with options of OrderDirection (singluar) if you want, or just integer/char/string.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant