Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom PR comment template gone #40

Closed
timkrins opened this issue Oct 15, 2024 · 1 comment
Closed

Custom PR comment template gone #40

timkrins opened this issue Oct 15, 2024 · 1 comment

Comments

@timkrins
Copy link

timkrins commented Oct 15, 2024

Hello,

We were using the custom template option for the PR comment - and I thought I had broken something when the PR comment reverted back to the default.

Turns out I think it was removed purposefully in #38

I will fix our own repo to github-actions-ctrf@0.0.42 for now.

But - can I bring it back?

Also, architecture-wise, can I suggest that all of the templates are rendered via handlebars - even the default ones - as this would probably result in less code, and super-simple customisable functionality.

@Ma11hewThomas
Copy link
Contributor

Hello @timkrins,

Apologies for the oversight — you're right that the pr-message argument was mistakenly removed.

When we introduced the ability to post all summary views, including custom ones, to pull requests using the --pull-request argument and the new pull-request method, the --pr-message argument was inadvertently removed without a deprecation notice.

I've restored it in #41 version (v0.0.45).

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants