Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule for gherkin-c relies on mirror repos which are going away #39

Closed
Tracked by #1550
mattwynne opened this issue Aug 11, 2022 · 4 comments
Closed
Tracked by #1550

Comments

@mattwynne
Copy link
Member

🤔 What's the problem you've observed?

This repo relies on the https://github.com/cucumber/gherkin-c mirror repo, generated from the main https://github.com/cucumber/common repo. We have a strategy (cucumber/common#1550) to retire these mirror repos and the infrastructure that maintains them.

✨ Do you have a proposal for making it better?

Once the Gherkin project has been moved out of the monorepo, we'll need to either update it to continue publishing a mirror repo of gherkin-c, or ideally we'd change this project to be able to handle a submodule that contains the whole gherkin project. It seems that would be simpler.

📚 Any additional context?

https://github.com/orgs/cucumber/projects/12


This text was originally generated from a template, then edited by hand. You can modify the template here.

@tmcgilchrist
Copy link
Contributor

#41 switches to the main https://github.com/cucumber/common repo.

@mattwynne
Copy link
Member Author

@tmcgilchrist thanks, but I think there's been a misunderstanding. The code for gherkin has moved into the https://github.com/cucumber/gherkin repo

@tmcgilchrist
Copy link
Contributor

tmcgilchrist commented Nov 30, 2022 via email

@mpkorstanje
Copy link
Contributor

Resolved by #41.

@mattwynne the PR had the correct url, the url in the message was a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants