Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CucumberHtmlStream CSS and JS args should have sane defaults #342

Closed
davidjgoss opened this issue Jan 2, 2025 · 0 comments · Fixed by #344
Closed

CucumberHtmlStream CSS and JS args should have sane defaults #342

davidjgoss opened this issue Jan 2, 2025 · 0 comments · Fixed by #344
Labels
enhancement New feature or request good first issue Good for newcomers language: javascript

Comments

@davidjgoss
Copy link
Contributor

davidjgoss commented Jan 2, 2025

Currently CucumberHtmlStream takes 2 constructor arguments, for the paths to the CSS and JS to be inlined in the HTML. It's right that these can be customised, but they should default to the built-in CSS and JS that the package provides, rather than consumers having to know where they are and resolve the paths themselves.

In other words, I should be able to do:

const stream = new CucumberHtmlStream()

and have that include the default CSS and JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers language: javascript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant