Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger symbol highlight on selection change #2604

Closed
AndreasArvidsson opened this issue Jul 30, 2024 · 3 comments · Fixed by #2751
Closed

Trigger symbol highlight on selection change #2604

AndreasArvidsson opened this issue Jul 30, 2024 · 3 comments · Fixed by #2751
Assignees
@AndreasArvidsson

Comments

@AndreasArvidsson
Copy link
Member

In vscode we can trigger editor.action.wordHighlight.trigger

Only on pre and post actions?
@AndreasArvidsson AndreasArvidsson changed the title Triggers symbol highlight on selection change Trigger symbol highlight on selection change Jul 30, 2024
@pokey
Copy link
Member

pokey commented Jul 30, 2024

Yeah interesting to think through when to do it. And we'd prob need a flag on setSelections, otherwise ide wouldn't know it's pre / post

@AndreasArvidsson
Copy link
Member Author

Or a separate editor method?

@AndreasArvidsson
Copy link
Member Author

But an option is probably better.

@AndreasArvidsson AndreasArvidsson self-assigned this Jan 24, 2025
@AndreasArvidsson AndreasArvidsson mentioned this issue Jan 24, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2025
@AndreasArvidsson
Highlight word when setting selection (#2751)
90f3bde 
In vscode if you click on a word with the mouse corresponding words are
highlighted. When using cursorless to set selection this doesn't happen
on main.

Fixes #2604

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight word when setting selection cursorless-dev/cursorless
2 participants
@pokey @AndreasArvidsson