Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings #667

Open
lenvm opened this issue Dec 12, 2024 · 1 comment
Open

Build warnings #667

lenvm opened this issue Dec 12, 2024 · 1 comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@lenvm
Copy link
Collaborator

lenvm commented Dec 12, 2024

Expected Behavior

Platform.io should build without warnings.

Actual Behavior

Warnings are created during the build process. Some may be less important, and others may actually hint towards a problem.

The following output is generated during the build process using Platform.io:

Issue in source code:

Compiling .pio/build/esp32dev/src/src/battery/KIA-HYUNDAI-HYBRID-BATTERY.cpp.o
/Battery-Emulator/Software/Software.ino:150:71: warning: unsigned conversion from 'long long int' to 'uint32_t' {aka 'long unsigned int'} changes value from '1099511627775' to '4294967295' [-Woverflow]
  150 | void set(uint8_t pin, bool direction, uint32_t pwm_freq = 0xFFFFFFFFFF) {
      |                                                                       ^

Issue in library used:

Compiling .pio/build/esp32dev/src/src/lib/miwagner-ESP32-Arduino-CAN/CAN.c.o
Software/src/lib/miwagner-ESP32-Arduino-CAN/CAN.c: In function 'CAN_init':
Software/src/lib/miwagner-ESP32-Arduino-CAN/CAN.c:181:9: warning: implicit declaration of function 'gpio_matrix_out'; did you mean 'gpio_iomux_out'? [-Wimplicit-function-declaration]
  181 |         gpio_matrix_out(CAN_cfg.tx_pin_id, TWAI_TX_IDX, 0, 0);
      |         ^~~~~~~~~~~~~~~
      |         gpio_iomux_out
Software/src/lib/miwagner-ESP32-Arduino-CAN/CAN.c:182:9: warning: implicit declaration of function 'gpio_pad_select_gpio'; did you mean 'esp_rom_gpio_pad_select_gpio'? [-Wimplicit-function-declaration]
  182 |         gpio_pad_select_gpio(CAN_cfg.tx_pin_id);
      |         ^~~~~~~~~~~~~~~~~~~~
      |         esp_rom_gpio_pad_select_gpio
Software/src/lib/miwagner-ESP32-Arduino-CAN/CAN.c:186:9: warning: implicit declaration of function 'gpio_matrix_in' [-Wimplicit-function-declaration]
  186 |         gpio_matrix_in(CAN_cfg.rx_pin_id, TWAI_RX_IDX, 0);
      |         ^~~~~~~~~~~~~~

Steps to Reproduce the Problem

  1. Build the code (a467575) with Platform.io
  2. Check the output of the build process

Settings

  • Software version: a467575a
@lenvm lenvm added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 12, 2024
@dalathegreat
Copy link
Owner

The 'long long int' to 'uint32_t' is fixed in PR #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants