Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webs server display of "Contactors controlled by emulator, state:" not working correctly #679

Open
davidhgriffiths opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@davidhgriffiths
Copy link

davidhgriffiths commented Dec 18, 2024

Expected Behavior

When the contactors open after an inverter request, the web server should display the OFF state.

Actual Behavior

When the contactors open after an inverter request the web server continues to display the ON state

I think the bug is caused by the absence of the following line at about line 128 of webserver.cpp

datalayer.system.status.contactors_engaged = false;

Currently datalayer.system.status.contactors_engaged only gets set to false if contractor opening is requested from the web page, not if it is requested by the inverter or estop

@lenvm lenvm added the bug Something isn't working label Dec 20, 2024
@mvgalen
Copy link
Collaborator

mvgalen commented Jan 2, 2025

Just so that I understand the issue correct: You mean that currently if an inverter request opening of contactors it does not show on the webpage? For which inverter have you seen this?

@davidhgriffiths
Copy link
Author

Yes your understanding is correct - if the inverter requests opening of the contractors the contractors open but the web page continues to show them closed. The inverter is a Solax X3 G4. With the change I suggested it works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants