Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs option to maintain aspect ratio #4

Closed
danielmorell opened this issue Jan 1, 2020 · 1 comment
Closed

Needs option to maintain aspect ratio #4

danielmorell opened this issue Jan 1, 2020 · 1 comment
Assignees
@danielmorell
Labels
CLI Has to do with the CLI interface JSON Has to do with the JSON configs New Feature New feature or request
Milestone
1.0.0

Comments

@danielmorell
Copy link
Owner

danielmorell commented Jan 1, 2020 •
edited
Loading

There is currently no way to keep the original aspect ratio of an image. Keeping the orientation of the image is a good start, but this is an important feature to make this a well rounded image optimization tool.

We should add --keep-aspect CLI parameter and a keep-aspect JSON config option. The CLI parameter should also be added to the multi-version method.
@danielmorell danielmorell added the New Feature New feature or request label Jan 1, 2020
@danielmorell danielmorell added this to the 1.0.0 milestone Jan 1, 2020
@danielmorell danielmorell self-assigned this Jan 1, 2020
@danielmorell danielmorell added CLI Has to do with the CLI interface JSON Has to do with the JSON configs labels Jan 1, 2020
danielmorell added a commit that referenced this issue Jan 10, 2020
@danielmorell
Added #4 --keep-aspect and changed --ignore-orientation to --keep-ori…
c11b518 
…entation to be consistent
@danielmorell
Copy link
Owner Author

This feature has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmorell danielmorell

Labels
CLI Has to do with the CLI interface JSON Has to do with the JSON configs New Feature New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@danielmorell