You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// The probabilities for each 3D-3D point correspondence if available
std::vector<double> &point_probabilities,
// Output: the found inliers
std::vector<bool>& inliers,
// Output: the found 6D pose
std::vector<double> &fundamental_matrix,
// The images' sizes
int h1, int w1, int h2, int w2,
only supports integer image sizes.
As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.
In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.
Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.
Best,
Johan
The text was updated successfully, but these errors were encountered:
Hi,
Currently the python wrapper, see e.g. here:
graph-cut-ransac/src/pygcransac/src/gcransac_python.cpp
Lines 721 to 731 in 37f7469
only supports integer image sizes.
As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.
In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.
Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.
Best,
Johan
The text was updated successfully, but these errors were encountered: