Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practice suggestion, Change the @ connection to be an & instead. #590

Open
GoodBoyDigital opened this issue Jun 9, 2021 · 1 comment
Open

Best practice suggestion, Change the @ connection to be an & instead. #590

GoodBoyDigital opened this issue Jun 9, 2021 · 1 comment
Labels
enhancement Help Wanted
Milestone
1.9.4

Comments

@GoodBoyDigital
Copy link

Hello! Firstly thank you devs for creating and sharing this plugin, its so useful for many of our projects!

Recently our analytics teams have fed back to us suggesting that our analytics is concatenating our data with @ as opposed to & which is considered a better practice.

I would be great to understand the reason the use of @ was chosen over & for this project as you guys will know a lot more about this than we do :D

If this is jut a legacy thing, would be happy to PR a change to update the @ to a &

cheers!
@victorsosa
Copy link
Collaborator

you are welcome to do it

@victorsosa victorsosa added this to the 1.9.2 milestone Mar 24, 2022
@victorsosa victorsosa modified the milestones: 1.9.2, 1.9.3 Sep 29, 2022
@victorsosa victorsosa modified the milestones: 1.9.3, 1.9.4 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Help Wanted
Projects
None yet
Milestone
1.9.4
Development

No branches or pull requests
2 participants
@victorsosa @GoodBoyDigital