Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for workflow ID reuse policy #3909

Open
kaibocai opened this issue Dec 19, 2023 · 9 comments
Open

Add example for workflow ID reuse policy #3909

kaibocai opened this issue Dec 19, 2023 · 9 comments
Assignees
Labels
area/workflow content/missing-information More information requested or needed P1 waiting-on-code-pr The code PR needs to be merged before the docs are updated
Milestone

Comments

@kaibocai
Copy link
Contributor

kaibocai commented Dec 19, 2023

What content needs to be created or modified?

Reference to dapr/dapr#7101 and dapr/dapr#7308, workflow ID reuse policy support is ready.

Describe the solution you'd like

Add examples for explaining workflow ID reuse policy

Where should the new material be placed?

Examples should be added somewhere here https://github.com/kaibocai/docs/tree/7e79a7f0bb725da707a3e2a713925b74ac74b877/daprdocs/content/en/developing-applications/building-blocks/workflow

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

dapr/dapr#7101
dapr/dapr#7308

Additional context

@kaibocai kaibocai added the content/missing-information More information requested or needed label Dec 19, 2023
@kaibocai
Copy link
Contributor Author

/assign

@msfussell msfussell added this to the 1.13 milestone Feb 7, 2024
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Feb 7, 2024
@kaibocai
Copy link
Contributor Author

kaibocai commented Feb 7, 2024

I just recall that the SDK updates for reuse ID were paused when we worked on the .NET SDK updates for ID reuse support, the discussion about refactoring the design dapr/dapr#6434 was brought up by the .NET SDK repo maintainer and the SDK updates are paused. Currently, customers cannot use this feature as SDKs don't have support for it.
I suggest pushing this doc update to 1.14 after we finish refactoring the design and adding support for SDKs.

cc @cgillum

@hhunter-ms hhunter-ms modified the milestones: 1.13, 1.14 Feb 14, 2024
@cgillum
Copy link
Contributor

cgillum commented Feb 16, 2024

@kaibocai I don't think it makes sense to pause all SDK work because of a small change we want to make to the SkipIfExists policy. IIRC, the proposed change only impacts runtime and API behavior, but not the SDK behavior. I think we should do the work to complete the SDKs so that developers can start using them and getting value from them in the 1.13 timeframe (which was part of our published 1.13 roadmap, right?). We can make adjustments as necessary in 1.14 when we can make a corresponding runtime change but I don't see any reason to pause SDK work for something as small as this.

@kaibocai
Copy link
Contributor Author

Thank you, @cgillum. I'll proceed with the SDK development. In fact, Java already had a PR for review concerning this feature. I plan to collaborate with another SDK owner to incorporate support for this feature. However, given our current timeline, it's possible that this update may not be included in the 1.13 release.

@msfussell
Copy link
Member

msfussell commented Jun 19, 2024

@cgillum @kaibocai - What was the conclusion on this issue?

@msfussell
Copy link
Member

@cgillum @kaibocai - Can one of you give an update on this. Is my understanding correct
-This feature was added in v1.13 and is not currently document (hence the PR)

  • This needs to be added to all WOrkflow API in the SDKs (hence the example in the PR use DurableTaskFramework which is wrong)
  • Do any of the SDKs plan to have this in v1.14 timeframe?

@cgillum
Copy link
Contributor

cgillum commented Jul 10, 2024

My understanding at this point is that the feature was added, but only a subset of Durable Task SDKs support it. Right now, it might only be the Go SDK.

I took a quick look, and it appears that some PRs were created for .NET and Java, but ended up getting stalled for one reason or another:

I'm not aware of whether any work was started for Python and JavaScript, nor am I aware of any timelines.

IIRC, 1.14 will be closing soon, so 1.15 might be more realistic for having this work done. However, work/discussions may be needed to get the appropriate teams/developers aligned on prioritizing and completing it.

@hhunter-ms
Copy link
Collaborator

This isn't supported in any Dapr SDKs yet - pushing to 1.15.

@hhunter-ms hhunter-ms modified the milestones: 1.14, 1.15 Jul 16, 2024
@hhunter-ms
Copy link
Collaborator

@kaibocai @cgillum should this be bumped to 1.16?

@hhunter-ms hhunter-ms modified the milestones: 1.15, 1.16 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow content/missing-information More information requested or needed P1 waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants