Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues rolling into google3 (from the sdk) #3969

Open
devoncarew opened this issue Jan 22, 2025 · 1 comment
Open

issues rolling into google3 (from the sdk) #3969

devoncarew opened this issue Jan 22, 2025 · 1 comment

Comments

@devoncarew
Copy link
Member

I'm seeing issues rolling the recent ~6 commits into google3:

.../dartdoc/bin/main.dart:15:24: Error: The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'.
 - 'PackageMeta' is from 'package:dartdoc/src/package_meta.dart' ('.../dart/dartdoc/lib/src/package_meta.dart').
 - 'LibraryElement' is from 'package:analyzer/dart/element/element.dart' ('.../dart/analyzer/lib/dart/element/element.dart').
 - 'ResourceProvider' is from 'package:analyzer/file_system/file_system.dart' ('.../dart/analyzer/lib/file_system/file_system.dart').
 - 'LibraryElement2' is from 'package:analyzer/dart/element/element2.dart' ('.../dart/analyzer/lib/dart/element/element2.dart').
    Google3PackageMeta.fromElement,
                       ^


ERROR: dart/dartdoc/bin/main.dart:15
The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'. #argument_type_not_assignable

    Google3PackageMeta.fromElement,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@srawlins
Copy link
Member

That roll will require a patch at dart/dartdoc/bin/main.dart:15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants