Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance kernel AST verifier to detect dangling references #59755

Open
alexmarkov opened this issue Dec 18, 2024 · 0 comments
Open

Enhance kernel AST verifier to detect dangling references #59755

alexmarkov opened this issue Dec 18, 2024 · 0 comments
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cfe-testing Issues related to testing of the CFE. triaged Issue has been triaged by sub team type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-enhancement A request for a change that isn't a bug

Comments

@alexmarkov
Copy link
Contributor

Kernel AST verifier (pkg/kernel/lib/verifier.dart) can collect/mark all AST nodes which are directly reachable from Component and then check that all references within AST point to the reachable nodes. This would ensure there are no dangling references in the AST and would allow us to catch various bugs related to the incorrect tree-shaking earlier (currently such bugs show up only after kernel is serialized and then deserialized).

@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-enhancement A request for a change that isn't a bug area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Dec 18, 2024
@a-siva a-siva added the triaged Issue has been triaged by sub team label Dec 18, 2024
@johnniwinther johnniwinther added the cfe-testing Issues related to testing of the CFE. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cfe-testing Issues related to testing of the CFE. triaged Issue has been triaged by sub team type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants