Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix analysis options discovery in the presence of workspaces #59848

Open
pq opened this issue Jan 6, 2025 · 3 comments
Open

[CP] Fix analysis options discovery in the presence of workspaces #59848

pq opened this issue Jan 6, 2025 · 3 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.

Comments

@pq
Copy link
Member

pq commented Jan 6, 2025

See: #56552

This affects folks using multiple analysis options files w/ workspaces.

Risk of merge is low.

Change: https://dart-review.googlesource.com/c/sdk/+/403203
@pq pq added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 6, 2025
@dart-github-bot
Copy link
Collaborator

Summary: Workspace analysis options discovery is broken when multiple analysis options files are used. This change fixes the issue.

@dart-github-bot dart-github-bot added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jan 6, 2025
@athomas
Copy link
Member

athomas commented Jan 7, 2025

LGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Jan 7, 2025
copybara-service bot pushed a commit that referenced this issue Jan 7, 2025
@pq
[stable] Fix analysis options discovery in the presence of workspaces
46a20c1 
Bug: #56552
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/390082
Cherry-pick-request: #59848
Change-Id: I1cf8ec10203a2b1bb11eafd16938ceb4f965c03c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403203
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
@pq
Copy link
Member Author

pq commented Jan 7, 2025

Thanks! And thanks for fixing up the whitespace in 46a20c1 @itsjustkevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pq @vsmenon @itsjustkevin @mit-mit @athomas @dart-github-bot