Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export strategy of turf library #169

Closed
lukas-h opened this issue Feb 16, 2024 · 0 comments · Fixed by #177
Closed

Fix export strategy of turf library #169

lukas-h opened this issue Feb 16, 2024 · 0 comments · Fixed by #177
Assignees
Labels
enhancement New feature or request

Comments

@lukas-h
Copy link
Member

lukas-h commented Feb 16, 2024

I moved this to a separate, new issue:

     Exactly, so far none of the boolean functions have been exported at all. I have exported all boolean functions as part of booleanWithin #167 in `package:turf/boolean.dart`. But we need to take a closer look:
  • package:turf/turf.dart should export all functionality, but a lot is missing (boolean functions among others)
  • package:turf/intersection.dart is missing
  • package:turf/invariant.dart is missing
  • package:turf/line_intersect.dart is missing
  • package:turf/line_slice.dart is defined as library turf_along. Seems to be an copy paste error.
  • package:turf/extensions.dart and package:turf/cluster.dart are the only meta functionality directly exported.
  • package:turf/meta.dart has all meta files except extensions.dart. Interesting, that meta also has export 'src/line_segment.dart' hide lineSegment;

Seems to have grown historically. Maybe we should take another look at it together? @lukas-h

Originally posted by @jsiedentop in #151 (comment)

@jsiedentop jsiedentop linked a pull request Feb 29, 2024 that will close this issue
@jsiedentop jsiedentop added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants