Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equality to 10 checked twice #6

Open
michaelaye opened this issue Apr 21, 2022 · 0 comments
Open

equality to 10 checked twice #6

michaelaye opened this issue Apr 21, 2022 · 0 comments

Comments

@michaelaye
Copy link

left_status = (100 if status_tmp == 10 else (status_tmp * 10 + 5 if status_tmp <= 10 else -1))

I believe the 2nd comparison should be simply status_tmp <10 because you check for ==10 before.
It doesn't harm, but confuses the reading of the code.

Thanks for this, very interesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant