Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgb: allow mapping RGB555 palette to other common colour palettes (eg. RGB565) #102

Open
deltabeard opened this issue May 10, 2024 · 1 comment
Labels
diff: intermediate Medium difficulty enhancement New feature or request feat: low-impact A low impact feature; not important but desired.

Comments

@deltabeard
Copy link
Owner

RGB555 isn't very common, so it will be useful if the look up table mapped directly with the output colour format rather than outputting RGB555 and then the user having to convert RGB555 to their required colour format.

This issue depends on CGB support.

@deltabeard deltabeard added enhancement New feature or request diff: intermediate Medium difficulty feat: low-impact A low impact feature; not important but desired. labels May 10, 2024
@Mr-PauI
Copy link

Mr-PauI commented Jun 5, 2024

CGB support sounds great; I deal with the palette conversion when the values are changed, since so long as it is in a valid 16-bit format the output translates to the frame buffer/display correctly. The output format changed part way through my implementation when I upgraded the graphics library. 565 is much more common; though bgr instead of rgb is also something I see with the displays for microcontrollers. Again, so long as the table values are in a format appropriate for the target system or API, they should translate into appropriate values for the display/frame buffer.

I appreciate all your work on this project.

Forgive my ignorance of the CGB specific functions if none of this applies; I'm still digesting the gameboy's programming manual's super gameboy section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff: intermediate Medium difficulty enhancement New feature or request feat: low-impact A low impact feature; not important but desired.
Projects
None yet
Development

No branches or pull requests

2 participants