Script tags added after body close tag when autorequiring #14

iguatemigarin · 2017-10-13T18:59:29Z

Before compilation

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="styles/reset.css">
    <link rel="stylesheet" href="styles/app.css">
    <link rel="stylesheet" href="fonts/font.css">
</head>
<body>
    <div id="app-root"></div>
    <script src="javascripts/vendor.js"></script>
    <script src="javascripts/app.js"></script>
</body>
</html>

After compilation

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="styles/reset.css">
    <link rel="stylesheet" href="styles/app.css">
    <link rel="stylesheet" href="fonts/font.css">
</head>
<body>
    <div id="app-root"></div>
    <script src="javascripts/vendor.js"></script>
    <script src="javascripts/app.js"></script>
</body>
<script src="/sw-precache.js"></script>
<script>if ('serviceWorker' in navigator) navigator.serviceWorker.register('/sw-precache.js')</script>
</html>

Expected result

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="styles/reset.css">
    <link rel="stylesheet" href="styles/app.css">
    <link rel="stylesheet" href="fonts/font.css">
</head>
<body>
    <div id="app-root"></div>
    <script src="javascripts/vendor.js"></script>
    <script src="javascripts/app.js"></script>
<script src="/sw-precache.js"></script>
<script>if ('serviceWorker' in navigator) navigator.serviceWorker.register('/sw-precache.js')</script>
</body>
</html>

sw-precache-brunch/index.js

Line 35 in a415f2f

$('html').append(swSource, registrationScript);

I suggest changing the selector to the body tag instead of the html tag.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Script tags added after body close tag when autorequiring #14

Script tags added after body close tag when autorequiring #14

iguatemigarin commented Oct 13, 2017 •

edited

Loading

Script tags added after body close tag when autorequiring #14

Script tags added after body close tag when autorequiring #14

Comments

iguatemigarin commented Oct 13, 2017 • edited Loading

Before compilation

After compilation

Expected result

iguatemigarin commented Oct 13, 2017 •

edited

Loading