Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Deno 0.35.0 #1

Open
lucacasonato opened this issue Mar 8, 2020 · 5 comments · May be fixed by #2
Open

Doesn't work with Deno 0.35.0 #1

lucacasonato opened this issue Mar 8, 2020 · 5 comments · May be fixed by #2

Comments

@lucacasonato
Copy link

Issues:

  • Deno.readdirSync was renamed to Deno.readDirSync
  • Deno.readdir was renamed to Deno.readDir
  • Deno.isTTY was renamed to Deno.isatty
  • Strict mode things
@kevinkassimo
Copy link
Member

  • Deno.isTTY was renamed to Deno.isatty

Technically isatty is more powerful than just renaming (I did that PR).

Anyways I will look into this next week (you know, dead week + final exams...)

@lucacasonato
Copy link
Author

  • Deno.isTTY was renamed to Deno.isatty

Technically isatty is more powerful than just renaming (I did that PR).

Anyways I will look into this next week (you know, dead week + final exams...)

Great 👍. I indeed know 😅

@KSXGitHub KSXGitHub linked a pull request Apr 11, 2020 that will close this issue
@hyperupcall
Copy link

if there is interest, i was able to migrate most calls to the new api surface - but my progress was stalled due to failing to await some deno apis. (explained more in detail in draft pr #3). i'm not exactly sure which apis i forgot to await and i feel like this puts us closer to making this usable for deno (0.43.0), so i created a draft pr in case someone else wants to pick up on this work

@ralyodio
Copy link

doesn't work with 1.16 either

@ralyodio
Copy link

still not working in deno 1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants