Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing context from a protocol crate to an user callback #13

Open
dequbed opened this issue Sep 11, 2022 · 1 comment
Open

Allow passing context from a protocol crate to an user callback #13

dequbed opened this issue Sep 11, 2022 · 1 comment
Milestone

Comments

@dequbed
Copy link
Owner

dequbed commented Sep 11, 2022

This one is especially important for a mechanism like EXTERNAL. Callbacks are per-config and have no per-session data making it very annoying to make decisions based on e.g. a provided TLS client certificate.

A possible solution would be to also use the property system here extending the SessionData passed into callbacks already.

I'm also very much open to alternative suggestions!

This is a good first issue since SessionData is only seen by callback and (possibly) the protocol crate and the property system could be used as-is if that ends up being the chose solution.

@dequbed dequbed added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 11, 2022
@dequbed dequbed modified the milestones: v2.0.0, v2.1.0 Feb 4, 2023
@dequbed dequbed modified the milestones: v2.1.0, v3.0.0 Oct 15, 2024
@dequbed dequbed removed help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 15, 2024
@dequbed
Copy link
Owner Author

dequbed commented Oct 15, 2024

As a note for prospective fixers or future me: This issue sadly isn't easy (anymore) since SessionData has been (accidentally) ossified into the public API. This means this issue has to be solved in a breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant