You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just started using your library and thought sharing my experience (as an rsasl newbie) could help improve it. I was confused about the name step64 because I expected it to have something to do with 32-bit vs 64-bit systems. Maybe it's just me.
But maybe step_base64 would be a better name?
PS: I really hope to get the rsasl integration done soon. As far as I see, this could work out really well 🙏🏻 So... thanks a lot for this crate!
The text was updated successfully, but these errors were encountered:
The main reason why it's called step64 is a hold-over from gsasl; this crate started as Rust bindings to it (which you can still find in the 1.X.X branch), and in that library the base64-wrapping function has the name gsasl_step64.
I'm not particularly beholden to the name, so I would merge a PR adding an alias function with a more appropriate name, your step_base64 sounds quite decent in that regard.
One question though; I did try to document the step64 method to point out it's exact purpose as succinctly as feasible, so I'm surprised anyone would mistake it for a 32-bit/64-bit issue. Can the documentation be improved so that others don't make the same mistake?
... first, and assumed there might be something I don't know about SASL yet. SASL extensions I don't know yet, etc. But it's really maybe just me: In IMAP you sometimes have 64 suffixes that distinguish between a 32 and 64 bit number. I was thinking in the same direction and wondered if this is communicated.
Hello!
I just started using your library and thought sharing my experience (as an
rsasl
newbie) could help improve it. I was confused about the namestep64
because I expected it to have something to do with 32-bit vs 64-bit systems. Maybe it's just me.But maybe
step_base64
would be a better name?PS: I really hope to get the
rsasl
integration done soon. As far as I see, this could work out really well 🙏🏻 So... thanks a lot for this crate!The text was updated successfully, but these errors were encountered: