Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity requests Approval for every transaction after cookie expires #49

Open
this-is-simon opened this issue Jul 6, 2021 · 4 comments

Comments

@this-is-simon
Copy link

I originally posted this in /frontend, but it was the wrong place. We're having an issue on Safari desktop with approvalRequired on the React web app we're building. I understand that Identity needs to request access again 1 week after login, but we are finding that even after approval is given, and the cookie is updated, Identity continues to request access for every transaction thereafter. i.e.:

Given that I'm using Safari
And I logged in 1 week ago with access level 4
When I attempt to buy a coin
Identity requires me to Approve transaction
And when I Approve transaction, then it is successful
But when I attempt another transaction
Then Identity asks for approval again
Despite the fact that the seed-hex-key in Cookies was correctly updated to last another week (i.e. now to expire 2 weeks from when I originally logged in)

We'd appreciate if you could look into this or provide some insight.

@maebeam
Copy link
Contributor

maebeam commented Jul 6, 2021

I'd love to help figure this out. First, I'm wondering about what your local setup looks like. Are you running a local copy of Identity? If not, are you using localhost to develop your app? Is this reproducible on a real domain like myapp.com and identity.bitclout.com? I've seen lots of weird behavior when developing Identity locally.

@this-is-simon
Copy link
Author

Thanks maebeam. I'm using identity.bitclout.com and a firebase hosted web-app, and that's where we noticed the issue. I also ran a local copy of Identity and I get the same behaviour.

@maebeam
Copy link
Contributor

maebeam commented Jul 7, 2021

Would you be willing to share the URL of the firebase app so I can play with it?

@this-is-simon
Copy link
Author

Of course, will send it to you privately :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants