From ab128e689860841fd20198b93b69c2d04adce648 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Sat, 14 Sep 2024 02:21:52 +0000 Subject: [PATCH 1/2] [dotnet] - Support 9.0 version - changes --- src/dotnet-mssql/README.md | 2 +- src/dotnet-mssql/devcontainer-template.json | 7 +++++-- src/dotnet-postgres/README.md | 2 +- src/dotnet-postgres/devcontainer-template.json | 7 +++++-- src/dotnet/README.md | 2 +- src/dotnet/devcontainer-template.json | 7 +++++-- 6 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/dotnet-mssql/README.md b/src/dotnet-mssql/README.md index 6fd6e794..79248b42 100644 --- a/src/dotnet-mssql/README.md +++ b/src/dotnet-mssql/README.md @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 8.0-bookworm | +| imageVariant | .NET version: | string | 9.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet-mssql/devcontainer-template.json b/src/dotnet-mssql/devcontainer-template.json index 49f901f3..fb987601 100644 --- a/src/dotnet-mssql/devcontainer-template.json +++ b/src/dotnet-mssql/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "dotnet-mssql", - "version": "3.3.2", + "version": "3.4.0", "name": "C# (.NET) and MS SQL", "description": "Develop C# and .NET Core based applications. Includes all needed SDKs, extensions, dependencies and an MS SQL container for parallel database development. Adds an additional MS SQL container to the C# (.NET Core) container definition and deploys any .dacpac files from the mssql .devcontainer folder.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet-mssql", @@ -11,17 +11,20 @@ "type": "string", "description": ".NET version:", "proposals": [ + "9.0", "8.0", "6.0", + "9.0-bookworm", "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", "8.0-noble", + "9.0-jammy", "8.0-jammy", "6.0-jammy", "6.0-focal" ], - "default": "8.0-bookworm" + "default": "9.0-bookworm" } }, "platforms": [ diff --git a/src/dotnet-postgres/README.md b/src/dotnet-postgres/README.md index e9c52dc8..56912763 100644 --- a/src/dotnet-postgres/README.md +++ b/src/dotnet-postgres/README.md @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 8.0-bookworm | +| imageVariant | .NET version: | string | 9.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet-postgres/devcontainer-template.json b/src/dotnet-postgres/devcontainer-template.json index 4a632075..64f65623 100644 --- a/src/dotnet-postgres/devcontainer-template.json +++ b/src/dotnet-postgres/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "dotnet-postgres", - "version": "3.2.2", + "version": "3.3.0", "name": "C# (.NET) and PostgreSQL", "description": "Develop C# and .NET Core based applications. Includes all needed SDKs, extensions, dependencies and a PostgreSQL container for parallel database development. Adds an additional PostgreSQL container to the C# (.NET Core) container definition.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet-postgres", @@ -11,17 +11,20 @@ "type": "string", "description": ".NET version:", "proposals": [ + "9.0", "8.0", "6.0", + "9.0-bookworm", "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", "8.0-noble", + "9.0-jammy", "8.0-jammy", "6.0-jammy", "6.0-focal" ], - "default": "8.0-bookworm" + "default": "9.0-bookworm" } }, "platforms": [ diff --git a/src/dotnet/README.md b/src/dotnet/README.md index 567768dc..ea1c30ea 100644 --- a/src/dotnet/README.md +++ b/src/dotnet/README.md @@ -7,7 +7,7 @@ Develop C# and .NET based applications. Includes all needed SDKs, extensions, an | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 8.0-bookworm | +| imageVariant | .NET version: | string | 9.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet/devcontainer-template.json b/src/dotnet/devcontainer-template.json index bde59155..4fff88fd 100644 --- a/src/dotnet/devcontainer-template.json +++ b/src/dotnet/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "dotnet", - "version": "3.2.2", + "version": "3.3.0", "name": "C# (.NET)", "description": "Develop C# and .NET based applications. Includes all needed SDKs, extensions, and dependencies.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/dotnet", @@ -11,17 +11,20 @@ "type": "string", "description": ".NET version:", "proposals": [ + "9.0", "8.0", "6.0", + "9.0-bookworm", "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", "8.0-noble", + "9.0-jammy", "8.0-jammy", "6.0-jammy", "6.0-focal" ], - "default": "8.0-bookworm" + "default": "9.0-bookworm" } }, "platforms": [ From 9bd5cc14b3724d429007b6237f3f9097ccbafba4 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Mon, 7 Oct 2024 14:11:44 +0000 Subject: [PATCH 2/2] changes as suggested --- src/dotnet-mssql/README.md | 2 +- src/dotnet-mssql/devcontainer-template.json | 4 ++-- src/dotnet-postgres/README.md | 2 +- src/dotnet-postgres/devcontainer-template.json | 4 ++-- src/dotnet/README.md | 2 +- src/dotnet/devcontainer-template.json | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/dotnet-mssql/README.md b/src/dotnet-mssql/README.md index 79248b42..6fd6e794 100644 --- a/src/dotnet-mssql/README.md +++ b/src/dotnet-mssql/README.md @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 9.0-bookworm | +| imageVariant | .NET version: | string | 8.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet-mssql/devcontainer-template.json b/src/dotnet-mssql/devcontainer-template.json index fb987601..1a86caf4 100644 --- a/src/dotnet-mssql/devcontainer-template.json +++ b/src/dotnet-mssql/devcontainer-template.json @@ -18,8 +18,8 @@ "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", - "8.0-noble", - "9.0-jammy", + "9.0-noble", + "8.0-noble", "8.0-jammy", "6.0-jammy", "6.0-focal" diff --git a/src/dotnet-postgres/README.md b/src/dotnet-postgres/README.md index 56912763..e9c52dc8 100644 --- a/src/dotnet-postgres/README.md +++ b/src/dotnet-postgres/README.md @@ -7,7 +7,7 @@ Develop C# and .NET Core based applications. Includes all needed SDKs, extension | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 9.0-bookworm | +| imageVariant | .NET version: | string | 8.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet-postgres/devcontainer-template.json b/src/dotnet-postgres/devcontainer-template.json index 64f65623..4fa2ba4b 100644 --- a/src/dotnet-postgres/devcontainer-template.json +++ b/src/dotnet-postgres/devcontainer-template.json @@ -18,8 +18,8 @@ "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", - "8.0-noble", - "9.0-jammy", + "9.0-noble", + "8.0-noble", "8.0-jammy", "6.0-jammy", "6.0-focal" diff --git a/src/dotnet/README.md b/src/dotnet/README.md index ea1c30ea..567768dc 100644 --- a/src/dotnet/README.md +++ b/src/dotnet/README.md @@ -7,7 +7,7 @@ Develop C# and .NET based applications. Includes all needed SDKs, extensions, an | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | .NET version: | string | 9.0-bookworm | +| imageVariant | .NET version: | string | 8.0-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/dotnet/devcontainer-template.json b/src/dotnet/devcontainer-template.json index 4fff88fd..f93abf3a 100644 --- a/src/dotnet/devcontainer-template.json +++ b/src/dotnet/devcontainer-template.json @@ -18,8 +18,8 @@ "8.0-bookworm", "6.0-bookworm", "6.0-bullseye", + "9.0-noble", "8.0-noble", - "9.0-jammy", "8.0-jammy", "6.0-jammy", "6.0-focal"