-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich UX for date range filter #188
Comments
I've went "all in" & adopted the changes myself via 2 seperate PR. |
Hi Martin,
Alternative for 1.: It's of course possible to implement both solutions, make the calendar popups the default input method (as most users are used to it) and provide an add-on option "advanced input mode" for people like me, who prefer typing dates. What do you think?
Thanks for this 👍🏻 But please always await feedback on your issues first and let yourself be assigned to it before implementing something that may be rejected. It would be a pity for your time. |
Hey Andreas,
my pleasure - as always in this repo of yours! 😎
Thought a bit longer about it, please see below for the outcome.
Awesome, thanks! 🤩👍🏻
In case there's a UI issue with using the date picker, it should be reported to Mozilla - working around bugs is our daily business as developers, but avoiding to use a component just because it's buggy while at the same time still actively developed (instead of abandoned code) seems to go against the principal of developing software in the first place, right? 😉
See 1. above for why it happened. I promise to await feedback next time - already proven by this comment 😉😎 |
Of course you're right. I will test the datepicker again in TB 85 and see, if this was already fixed.
To make clear it's actually clickable - agreed 👍🏻
I wouldn't do this. Every change in the date fields would directly start a new processing. Especially for larger date ranges this could take some time. Imagine someone wanted to change both date fields. After changing one field, they would have to wait until processing finishes to change the other. This would be kind of annoying. Having an Apply-Button gives more freedom to make changes without unwanted triggering of processing.
I think the X is quite common to clear a filter. Do you recommend something? I'm using tablericons for ThirdStats. Maybe one of these: |
Awesome! Let me know, if I can be of any (further) help! 😎
Awesome²! 😉 Though, I feel a bit sad that my PR is now mostly obsolete which in turn reduces my contributions to your awesome project which a lot, from my point of view at least. 🙁
I see... Let me think about this for a second... Coming from a C# background, I know off cancellation tokens which can be passed to tasks which - upon reception - immediately cancel themselves. Does Vue.JS offer something similar? If so, my suggested button removal wouldn't hurt anymore, because further changes would simply cancel prior executions & re-execute then.
Well, whenever it comes to filtering, I always have that "Y"-shaped icon for enabling & the same icon, but with a 50% smaller, red "X" overlay in its lower-right corner for disabling in mind.. 😅
Really looking forward to read your thoughts! Until then, stay healthy & have a good one! 🥳 |
Will do, thanks!
You already did quite a lot by filing reports and requests and sharing all your good, detailed thoughts, ideas and feedback. I don't see how one obsolete PR could diminish that.
Afaik there's no such functionality.
How exactly do you imagine that? Can you sketch it maybe? I like your interpretation of the viewport icons, I'll definitely try those out and post some screenshots here. We can then decide, which looks best. Thank you, stay well too! |
Will provide sketch tomorrow, time for 🛏 now.. 😅 |
@devmount Sorry for being that late, but both, day job & private engagements, took away all spare time up to now.. :( Maybe both button icons should be exchanged with each other as normally, such icons show what happens after being clicked instead of what has happened, i. e. prior to clicking them. |
No reason to be sorry for - we all have a life next to OSS 😅 Many thanks for your sketch! 👏🏻 I like the idea a lot but see the following problems:
I love the concept of highlighting value and button icon color in active state, that clearly shows, when a custom date range is set or when the default dates are set. |
😅👍🏻
My pleasure. 🥳🤘🏻
I'm desperately trying to convince you of the proposed icon change here as they're that much beautiful (for me at least 😅), so I'd like you to consider this real-world scenario:
There. You. Go. & thanks for that "hint" - it was the spark I've needed to come up with above's scenario. And yes, that's simply because the added "nerdyness" wasn't listed in 1.3.0's changelog (as expected for any geek/nerd feature - wouldn't be that much fun otherwise, right? 😉). But since you also didn't hint at it & using ThirdStats even for my work's collective mail account (with >10 years of support tickets! 🥳) means that much joy for me, I definitely have to make a mark on ThirdStats - no matter how long or much it takes! 😏 |
@devmount you've probably missed that notification, so may I ask if above's proposal is sufficient for implementation or if I can be of any help towards getting this (IMHO) improvement done? 😃 |
Thank you for the kind reminder 😅
Always a pleasure to read those comments of yours, making me smile everytime 😂 As much as I like your approach, not being able to see at first glance how to reset the filter decreases usability and unifying the two buttons into one makes things more complicated than adding value (IMHO). I imagine a reset button that's the same for every filter field (currently for folder selection and date range, in future also for contact selection), leaving no doubt for the user how to reset any filter to default state. Same for the apply button - I think it's best to have the same for every filter field. Currently only the date range filter needs an apply button, since all other filters are select fields which apply the filtering on select. So what I'll take and implement from our valuable discussion to this point is:
|
My pleasure. As always. 😎🥳
Again: my pleasure. Honestly! 🤜🏻
While I do agree with the former part of that paragraph, I refuse to accept the latter.
So, you prefer an "1 static icon for several, different reset action" approach over its "1 action, 1 icon visualizing the actual action" counterpart?
I have to disagree due to your own extension's options page which clearly states:
So applying should happen automatically as otherwise, the user must exactly think those additionally thought you try to avoid in the first place.
Thanks a lot! 🥳
Yes, yes, yes! 😍
Awesome. Just awesome! 🤩❤️ |
I agree, I don't like the 2 button solution either, but it's clear. And especially on form elements, I have to prefer clear over pretty (since the latter is always a matter of taste too...)
Of course! I'm looking forward to your ideas! This really helps a lot 💪🏻
I totally see your point here, and while I agree with your example, we're talking about filter fields only - not about a filter field and an option (which are way more different). So in my opinion it's totally okay for multiple filter fields to have the same apply and reset button.
I agree again! That's why I implemented e.g. the folders filter to apply directly on changing the select field. But with the date range filter (and possible future filters) it's different and more difficult, as I want to prevent unwanted processing. When the three mentioned points landed, let's see how we can further improve the filter area. |
While reading your mentioning in #273, I came up with yet another idea.. 😅
Well, here's my next SPOC attempt:
I agree with your
Of course, hence taken into consideration for my newest attempt above. 😎
Looking forward to! 🥳 |
Cross-referencing my notes on filter UX from #376
|
Thanks @koobs. I updated the description with a summarized task list. |
Is your feature request related to a problem? Please describe.
As kinda "follow-up" for #161, I'd like to request the UX enrichment of the aforementioned filter controls.
Describe the solution you'd like
Date period
or, better yet,Date range
since that reflects its actual functionality probably better than the current label's, hour-based filtering, suggestion.Describe alternatives you've considered
Using the current implementation is good, but as always: the more UI & UX comfort for the users, the happier they are & the better the reviews are. 😉😅
Edit (2022-06-12): Here are the currently open tasks I agree with summarized
The text was updated successfully, but these errors were encountered: