From dfcfb7f61ec004a02829655287bb6fe1ca1f3e20 Mon Sep 17 00:00:00 2001
From: Nicolas Mattia <nicolas.mattia@dfinity.org>
Date: Fri, 22 Jul 2022 16:26:22 +0200
Subject: [PATCH] Include glibc version in cache key (#765)

This includes the glibc version in the bootstrap cache key, to avoid
issues like this: https://github.com/dfinity/internet-identity/actions/runs/2717048520

While it's unclear why the issue actually occurred, the cache key is now
human readable for easier debugging in the future.
---
 .github/actions/bootstrap/action.yml | 29 +++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/.github/actions/bootstrap/action.yml b/.github/actions/bootstrap/action.yml
index 31e53acba8..6c2aa85192 100644
--- a/.github/actions/bootstrap/action.yml
+++ b/.github/actions/bootstrap/action.yml
@@ -3,15 +3,30 @@ description: Bootstrap the Internet Identity build environment
 runs:
   using: "composite"
   steps:
-    - id: uname
+    - id: platform
       shell: bash
       run: |
+        set -euo pipefail
+
         # print include system info relevant for cache compatibility
-        uname="$(uname -mpsr)"
-        echo "uname value: $uname"
-        uname_hash="$(echo "$uname" | shasum -a 256 | head -c 10)"
-        echo "uname hash value: $uname_hash"
-        echo "::set-output name=uname-hash::$uname_hash"
+        uname_sys=$(uname -s)
+        case "$uname_sys" in
+            Darwin)
+                echo "system is darwin ($uname_sys)"
+                ver=$(uname -r | sed 's/\./_/g')
+                echo "darwin version is '$ver'"
+                echo "::set-output name=platform-id::darwin-$ver"
+                ;;
+            Linux)
+                echo "system is linux ($uname_sys)"
+                glibc_version=$(ldd --version | head -n 1 | grep -oP 'ldd (.*) \K[[:digit:]]+\.[[:digit:]]+' | sed 's/\./_/g')
+                echo "glibc version is '$glibc_version'"
+                echo "::set-output name=platform-id::ubuntu-glibc-$glibc_version"
+                ;;
+            *)
+                echo uknown system "$uname_sys"
+                ;;
+        esac
 
     # cache ic-cdk-optimizer
     # NOTE: here we make sure to only cache ic-cdk-optimizer and _not_ e.g. the cargo target, since in some cases
@@ -20,7 +35,7 @@ runs:
     - uses: actions/cache@v2
       with:
         path: ~/.cargo/bin
-        key: cargo-bin-${{ hashFiles('**/Cargo.lock', 'rust-toolchain.toml') }}-${{ steps.uname.outputs.uname-hash }}
+        key: cargo-bin-${{ steps.platform.outputs.platform-id }}-${{ hashFiles('**/Cargo.lock', 'rust-toolchain.toml') }}
 
     - name: Bootstrap
       shell: bash