Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code of flask-dropzone duplicated in the code #658

Open
c8y3 opened this issue Dec 10, 2024 · 0 comments
Open

Code of flask-dropzone duplicated in the code #658

c8y3 opened this issue Dec 10, 2024 · 0 comments
Labels

Comments

@c8y3
Copy link
Contributor

c8y3 commented Dec 10, 2024

It seems that the code in namespace app.flask_dropzone is copy pasted from the python package Flask Dropzone (https://flask-dropzone.readthedocs.io/en/latest/) in version 1.5.4.
It would be better for maintenance (such as the application of security updates) to handle this dependence as any other, by adding it in the requirements.txt file.
It seems however, that there is a slight difference between the Flask Dropzone code and the one copied in DFIR-IRIS: when instantiating the Blueprint, parameters static_folder and static_url_path are not set:

blueprint = Blueprint('dropzone', __name__)
vs. https://github.com/helloflask/flask-dropzone/blob/1.5.4/flask_dropzone/__init__.py#L380.

@c8y3 c8y3 added the quality label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant