Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY work on app.iris_engine.reporter.reporter #659

Open
c8y3 opened this issue Dec 10, 2024 · 0 comments
Open

DRY work on app.iris_engine.reporter.reporter #659

c8y3 opened this issue Dec 10, 2024 · 0 comments
Labels

Comments

@c8y3
Copy link
Contributor

c8y3 commented Dec 10, 2024

Method get_case_timeline seems to be duplicated in class IrisReportMaker (

def get_case_timeline(caseid):
) and in its subclass IrisMakeDocReport (
def get_case_timeline(caseid):
).
There are other methods which seem very similar in these two classes.
This file could be cleaned up somewhat. Probably by preferring composition and the strategy pattern over inheritance.

@c8y3 c8y3 added the quality label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant