Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested library: busted #1

Open
italomaia opened this issue Feb 15, 2018 · 7 comments
Open

Suggested library: busted #1

italomaia opened this issue Feb 15, 2018 · 7 comments

Comments

@italomaia
Copy link

Testing library for lua: https://olivinelabs.com/busted/

@dibyendumajumdar
Copy link
Owner

thank you - will review. agree that best to have a standard unit test library included

@dibyendumajumdar
Copy link
Owner

btw Torch comes with a test framework too. See https://github.com/dibyendumajumdar/ravi-torch7/blob/master/doc/tester.md

@italomaia
Copy link
Author

Well, torch do seem to overlap with a lot of internal tools. Probably not the time to wonder if that is a good thing, but, wasn't there a warning that torch is being "replaced" by pyTorch? Should this distro rely so much in a soon-to-be defunct project? Not questioning torch greatness, of course. Just ... wondering.

@dibyendumajumdar
Copy link
Owner

Yes Torch is sadly now under maintenance. But that is okay as I expect to maintain and support my fork of Torch long term. Re the tools that overlap - that in itself is not an issue - I guess I have to review carefully whether the tool is used by enough projects. To be honest it may be that none of the libraries I am including use Busted (I haven't checked).

@italomaia
Copy link
Author

italomaia commented Feb 19, 2018

If you plan to keep your torch fork, long-term, maybe, shifting from non-core "under maintenance" libraries would be the way to go. In the long-run that would be less code to maintain. Just a thought.

@italomaia
Copy link
Author

Regarding busted usage, I've found that the libraries listed in the readme do not use busted.

Some fellow suggested busted usage for luasocket (and that's about it): lunarmodules/luasocket#227

@dibyendumajumdar
Copy link
Owner

Although it would be nice to migrate stuff in torch it is less of an issue, I guess easier option is to add the most commonly used unit testing framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants