Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control use of months constants (for JANUARY = 0 problem) #3317

Open
MizukiTemma opened this issue Jan 6, 2025 · 1 comment
Open

Control use of months constants (for JANUARY = 0 problem) #3317

MizukiTemma opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement This improves an existing feature needs-further-investigation This issue needs some further research/investigation
Milestone
Backlog

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Jan 6, 2025 •
edited
Loading

Motivation

We have already experienced two bugs which were related to months.JANUARY = 0 (#2598 and #3310). We should investigate whether there are other potential bugs due to this cause.

Proposed Solution

  • Check for use of months constants in the repository, expecially in context of regions and MT budget
  • If any bug prone points are found , fix them
  • Add tests to code lines with months constants (if applicable), even if they are currently working fine.

Alternatives

User Story

Additional Context

Design Requirements

Related Issues
@MizukiTemma MizukiTemma added the enhancement This improves an existing feature label Jan 6, 2025
@MizukiTemma MizukiTemma mentioned this issue Jan 6, 2025
Merged
@JoeyStk JoeyStk added the needs-further-investigation This issue needs some further research/investigation label Jan 14, 2025
@JoeyStk
Copy link
Contributor

JoeyStk commented Jan 14, 2025

Proposed solution: Identify all the if-statements not explicitly checking against null. Repair them. Then come up with a long term solution so this cannot happen again

@JoeyStk JoeyStk added this to the Backlog milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This improves an existing feature needs-further-investigation This issue needs some further research/investigation
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@JoeyStk @MizukiTemma