Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disables in link action tests #3343

Open
MizukiTemma opened this issue Jan 17, 2025 · 0 comments
Open

Remove disables in link action tests #3343

MizukiTemma opened this issue Jan 17, 2025 · 0 comments
Labels
enhancement This improves an existing feature needs-further-investigation This issue needs some further research/investigation

Comments

@MizukiTemma
Copy link
Member

Motivation

#3096 introduced tests for actions users can take for links. Due to some unknown difficulty some assertions are disabled in tests/cms/views/link_replace/test_link_actions.py.

Investigate the cause and find a solution. Remove the disables.

Proposed Solution

Following approaches were tried, but didn't succeed:

  • Set listeners.tests_running = True
    This lead to the problem that the tests in which this is applied never ends.
  • Set settings.LINKCHECK_DISABLE_LISTENERS = False
    Brought no effect

Alternatives

User Story

Additional Context

None

Design Requirements

Related Issues
@MizukiTemma MizukiTemma added enhancement This improves an existing feature needs-further-investigation This issue needs some further research/investigation labels Jan 17, 2025
@MizukiTemma MizukiTemma mentioned this issue Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This improves an existing feature needs-further-investigation This issue needs some further research/investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MizukiTemma