-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for js-joda #53
Comments
43 kb?!!! |
I think we should not recommend it for users :) |
Isn't the whole point of this library to make it easier for people to choose? I'll have to check what size is left in my app after tree shaking. |
Yeah, but the cost of supporting this library in official monorepo will be much incompatible with users, that are using this lib. It is still possible to make your own adapter. Just implement interface and publish npm package. |
For all people who need it nonetheless please head over to: https://github.com/prinzdezibel/date-io @dmtrKovalenko: May I ask you to reconsider your decision? Oftentimes one is not in the position to choose the date utility library used for a given project. Those people may have no choice but to stick with js-joda. Besides from that js-joda seems to be a very complete and mature library with "localization" batteries included. This may well justify its somewhat bigger size. I would be very happy to file a PR if you change your mind, @dmtrKovalenko. |
My main thoughts:
I am not really against of supporting a lot and a lot of libraries, but each new library makes support of @date-io harder and harder. If there is a reasonable answer why you are choosing js-joda instead of other libs, I think it should not be a problem to add this to the main repo
|
Our team's main reason to choose js-joda over any of the alternatives:
I'd love to hear that date-io is officially supporting js-joda! |
I also heavily use js-joda and would like to see date-io supporting it. |
@grantsru Please checkout this fork https://github.com/prinzdezibel/date-io (supports only v1.3.13 of @date-io/core for now) |
@prinzdezibel if you could extract and publish your date-io package separately from fork - I would love to add a link to the README |
@dmtrKovalenko What are your thoughts on supporting it officially in your project? (provided that my work is compatible with v2, of course) |
I'm also interested in support for My usecase: Kotlin's officially supported multiplatform datetime library Since our web frontend integrates with Kotlin-compiled JS code which is already using |
@dmtrKovalenko https://bundlephobia.com/package/@js-joda/core@4.0.0 is half the size of https://bundlephobia.com/package/moment@2.29.1 |
@dspiteself sorry for not answering I was sure that I responded, I am totally OK for supporting js-joda, so if you can get PR up to 100% coverage – I`ll merge and publish it |
One more interesting thing with js-joda is that JavaScript Temporal #466 is very close to js-joda mainly some renames and a few changes to JavaScript idiom. |
In our team's case (decision predates my involvement):
|
js-joda is an immutable date and time library which is often mentioned alongside the other alternatives to moment.js.
It would be great to include and would allow easy use with Material-UI Pickers.
The text was updated successfully, but these errors were encountered: