-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Kotlin #1
Comments
Hey @shekhargulati, I have no idea how to start exactly with the migration. If you have any specific idea, just tell me! I would start with the low level classes and work from bottom to up. In this actual library the The tests are no real unit tests, they are inspired/copied from the original Docker codebase and as such are quite high level. I guess that helps with the migration and ensures we don't completely break everything, so I would convert the tests only after the production code. |
Finished with d1ba6ee |
Follow-up in the docker-client: gesellix/docker-client#44 |
My philosophy behind the Docker client (and as such this repo, too) is to keep the Docker facing side as flexible as possible. Types might be less convenient, so I have no idea whether Kotlin is counter productive. That's what I want to learn and gain some experience.
My main motivation to introduce Kotlin is the library's client facing side of the libraries. A strongly typed api certainly helps to use a library given a capable IDE. That way, the lack of documentation might be compensated to a certain degree.
Things to keep in mind:
static
modifier in Kotlin.static someMethod(){}
could be converted to@JvmStatic fun someMethod()
, but it would also be valid to simply remove thestatic
modifier and makesomeMethod()
an instance method.See docker-client/docker-filesocket@620cc55 for a first try at converting from Groovy to Kotlin.
The text was updated successfully, but these errors were encountered: