Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown mode affects links #13

Open
Chew opened this issue Nov 14, 2017 · 8 comments
Open

Markdown mode affects links #13

Chew opened this issue Nov 14, 2017 · 8 comments

Comments

@Chew
Copy link

Chew commented Nov 14, 2017

30ff9fd146a361a4ee62e0d04878ef97

turns into

013454c90c91a1ccd7478d3aa8ffd615
@jclishman
Copy link

jclishman commented Nov 15, 2017 •
edited
Loading

Also effects emotes:
What I typed

What it output

Maybe add a toggle to only use */** for italics/bold?

I don't see why italics would need to be triggered by both * and _

@advaith1
Copy link
Contributor

advaith1 commented Nov 15, 2017 •
edited
Loading

@jclishman: Italics used to only be triggered with *, but since markdown also accepts _ for underline and I was used to using it, I added it in a PR.

@Chewsterchew are all the issues you make based on stuff I did in chat, lol

@Chew

This comment has been minimized.

Sign in to view
@advaith1
Copy link
Contributor

you want me to get screenshots?

@Chew

This comment has been minimized.

Sign in to view
@advaith1
Copy link
Contributor

Maybe add / to escape? That would be a solution to some cases where _ is not meant to italicize

But of course, detecting links should also be implemented.

@jclishman
Copy link

Yes, exactly what I was thinking.

@advaith1
Copy link
Contributor

#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Chew @jclishman @advaith1