Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] - Support for frameworks and libraries #136

Closed
dostonnabotov opened this issue Jan 2, 2025 · 8 comments · Fixed by #198
Closed

[Announcement] - Support for frameworks and libraries #136

dostonnabotov opened this issue Jan 2, 2025 · 8 comments · Fixed by #198
Labels
enhancement New feature or request in-progress This feature/issue is currently under development.

Comments

@dostonnabotov
Copy link
Owner

dostonnabotov commented Jan 2, 2025

What feature would you like to see?

Hey, there! 👋

We see that there's a demand from our community to include frameworks and libraries as well. Since we recently changed our snippets storage system, it makes adding support for frameworks and libraries much easier.

Here's the draft version of what it could look like:

new language selector with support for frameworks

Explanation

If the user clicks on the dropdown next to JavaScript, it will expand to show the frameworks. If the user clicks on the JavaScript itself, it will show the default behavior (snippets within JavaScript).

Benefits

A great thing about this approach is that we don't have to make much changes to storage system we recently implemented. We might have to add relationships to frameworks, so, they are in correct language dropdown.

If you’ve got suggestions or ideas, feel free to share them here. We’ll keep this issue updated as we implement this feature. So, stay tuned. 🚀

@dostonnabotov dostonnabotov added the enhancement New feature or request label Jan 2, 2025
@ACR1209
Copy link
Contributor

ACR1209 commented Jan 2, 2025

Cool feature! Could I work on this?

@dostonnabotov
Copy link
Owner Author

Cool feature! Could I work on this?

@Mathys-Gasnier, did you start working on it as well?

@dostonnabotov
Copy link
Owner Author

Cool feature! Could I work on this?

Yes, of course. Please share your thoughts on how to implement it. So, our maintainers can confirm it. Once confirmed, then, feel free to make a PR.

@ACR1209
Copy link
Contributor

ACR1209 commented Jan 2, 2025

Cool feature! Could I work on this?

Yes, of course. Please share your thoughts on how to implement it. So, our maintainers can confirm it. Once confirmed, then, feel free to make a PR.

Well, I see two main ways of doing it: 1) the easy way considering each framework as it's own "language" and just adding optional metadata to the language to set relations, or 2) allowing for categories subcategories that would accomplish the same thing. Personally I would prefer the first one as it seems better in terms of creating snippets and in ease of development; plus it would allow for other language metadata later on.

On the other hand, regarding the UX of the mockup presented, I don't know if it's better in this case to have the default value as a option like "Vanilla Javascript" as it wouldn't be clear for the user if the option expands the frameworks, selects plain JavaScript or both.

@Mathys-Gasnier
Copy link
Collaborator

I've already kinda started working on the backend of it.
What i'm doing is taking folders with braces [folder] and adding them in a subLanguages field in each language.
This will change a bit the structure of the json, I will fix existing use cases of the json, but if you want i can leave you to make the frontend changes to support those subLanguages in the select. I will let you know when the first half is merged

@ACR1209
Copy link
Contributor

ACR1209 commented Jan 2, 2025

I've already kinda started working on the backend of it.
What i'm doing is taking folders with braces [folder] and adding them in a subLanguages field in each language.
This will change a bit the structure of the json, I will fix existing use cases of the json, but if you want i can leave you to make the frontend changes to support those subLanguages in the select. I will let you know when the first half is merged

Ok, sounds good

@dostonnabotov dostonnabotov changed the title [Feature] - Support for frameworks and libraries [Announcement] - Support for frameworks and libraries Jan 3, 2025
@Mathys-Gasnier
Copy link
Collaborator

@ACR1209 The PR adding the support on the "backend" of this feature is merged, if you still want to open a PR updating the frontend, feel free to do it

@ACR1209
Copy link
Contributor

ACR1209 commented Jan 5, 2025

@ACR1209 The PR adding the support on the "backend" of this feature is merged, if you still want to open a PR updating the frontend, feel free to do it

Ok, I'll work on it!

@psychlone77 psychlone77 added the in-progress This feature/issue is currently under development. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress This feature/issue is currently under development.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants