Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] Need reviewers for managing Issues and PRs #30

Open
dostonnabotov opened this issue Dec 30, 2024 · 15 comments
Open

[Announcement] Need reviewers for managing Issues and PRs #30

dostonnabotov opened this issue Dec 30, 2024 · 15 comments
Labels
discuss Needs to be discussed by community help wanted Extra attention is needed

Comments

@dostonnabotov
Copy link
Owner

Hey, everyone!

As more people contributing to our project (which is awesome), it will be kinda harder for me to maintain and review the code snippets. Therefore, I'm looking for reviewers to review the code snippets to make sure they are actually helpful for developers.

I also noticed that @Mathys-Gasnier is already reviewing a lot of code snippets and finding out issues with them. Thank you very much. Appreciate your work. I wanted to ask: Is it okay if I assign you, @Mathys-Gasnier, as a reviewer for our project. Will you have available time to review? Let me know.

If anybody is willing to be part of reviewing and helping manage the issues and pull requests, let me know in this issue.

I'm not very familiar with some languages, like C++ and Rust, therefore, @saminjay was also helping me out as well. Thank you. Once we have some reviewers, we can divide the roles based on their expertise.

As always, I'm open to ideas. Let me know your thoughts.

@dostonnabotov dostonnabotov added help wanted Extra attention is needed discuss Needs to be discussed by community labels Dec 30, 2024
@psychlone77
Copy link
Collaborator

I could help out with reviewing some PRs. Mostly JavaScript, Python and CSS stuff will be possible.

@saminjay
Copy link
Collaborator

I would love to help out with reviewing PRs and managing Issues.
I am mostly familiar with JS, C++, Go and Python.

@dostonnabotov dostonnabotov pinned this issue Dec 30, 2024
@Mathys-Gasnier
Copy link
Collaborator

Yeah it's not a problem !
I have a lot of time (Will probably have a bit less in a couple of weeks, but still more than 5-6 hours a day) so reviewing stuff is not an issue and i really like the project.
Maybe creating a discord would be something interesting btw, to discuss stuff without having to open an issue for every little things.

On what languages i'm familiar with it's mostly, javascript/typescript, java, python and low level languages mainly C/C++ and Rust.
But i've worked a bit with C# and some other techs not long ago, so i'm pretty versatile.

@realvishalrana
Copy link
Contributor

Hi @dostonnabotov ,

I would love to help as a reviewer for this project. I have experience in JavaScript, React, Next.js, and CSS. Please let me know how I can assist!

Best,
Vishal Rana

@dostonnabotov
Copy link
Owner Author

dostonnabotov commented Dec 30, 2024

Thanks to everyone who is willing to be part of this project. To maintain trust and collaboration with reviewers, first, we will need to prove that you can contribute to the project well. As you contribute more, the more responsibility you will have. Hopefully, with this approach, we will build trusted maintainers for this awesome community.

I also noticed that @Yugveer06, @GreenMan36, @psychlone77 and @saminjay are heavily focusing on improving the code and adding new features. And, @Mathys-Gasnier is responsible for reviewing the pull requests. Special thanks to you all!

@dostonnabotov
Copy link
Owner Author

I just found out that there's a thing called CODEOWNERS, which you assign people to specific folders or files. When there's a pull request with change on that folder, assigned people will be notified and they need to review it before getting merged.

What do you think about it, @Mathys-Gasnier?

I'm open to other ideas as well.

@Mathys-Gasnier
Copy link
Collaborator

I think we could have two types of reviewers, global ones, that review changes for the project and for snippets, and snippets reviewers that are assigned one or more language to review snippets from

@realvishalrana
Copy link
Contributor

@Mathys-Gasnier I completely agree with this suggestion. Having two types of reviewers—global reviewers for overall project changes and snippets reviewers dedicated to specific languages—would streamline the review process. It ensures that domain experts can focus on language-specific snippets, while global reviewers oversee broader changes. This division of responsibility could significantly enhance the efficiency and quality of reviews. Let me know how I can contribute to implementing this!

@dostonnabotov
Copy link
Owner Author

Maybe creating a discord would be something interesting btw, to discuss stuff without having to open an issue for every little things.

I like the idea. What do you think about GitHub Discussions? I'm not much familiar with it yet, so let me know which one would be easier to maintain in the long run.

@Mathys-Gasnier
Copy link
Collaborator

I have lot's of experience with discord, and not much with github discussions, what i know is that most libs I contribute to have a discord... If you want we can always set it up together if you don't know how to create one

@dostonnabotov
Copy link
Owner Author

Ok. I will create a Discord server and share the link in a new issue.

@ACR1209
Copy link
Contributor

ACR1209 commented Jan 2, 2025

Hey, are you still looking for reviewers? If so, I would be down to help out!

I'm familiar with Python, Rust, JS, TS, Ruby and Haskell.

@pl44t
Copy link
Contributor

pl44t commented Jan 2, 2025

If you are still looking for reviewers, I would be happy to help with python, css, html, javascript.

@Mathys-Gasnier
Copy link
Collaborator

Hey, thanks all for volunteering on being reviewers.
Feel free to leave reviews on PRs if you want to give your opinion on new snippets/snippets changes !
If we see a PR has been getting lots of approval from the community it will better help us to decide if we should add it or not.

Like @dostonnabotov said, if we see you are cotributing a lot (adding snippets, reviewing and giving feedback) we will be able to talk with you to maybe make you a reviewer of certains snippets languages !

@Kol9yN
Copy link

Kol9yN commented Jan 3, 2025

I can review Bash, Vagrant(VirtualBox, VmWare), Ansible code snippets and add basic templates of it. Maybe something more a bit later, lets see how the going :) @dostonnabotov

@dostonnabotov dostonnabotov changed the title Need reviewers for managing issues and pull requests [ Announcement ] Need reviewers for managing Issues and PRs Jan 4, 2025
@dostonnabotov dostonnabotov changed the title [ Announcement ] Need reviewers for managing Issues and PRs [Announcement] Need reviewers for managing Issues and PRs Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Needs to be discussed by community help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants