-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Use PrismLight syntax highlighting instead of Prism to improve performance and reduce build size #94
Comments
WIP |
@dostonnabotov Whilst working in this area I noticed that we don't allow the user to change the style of the syntax highlighter itself. We have the code I was wondering if adding the ability to select the style of the highlighter theme was something we wish to add? Here is how I would envisage such a feature:
Please let me know if you think this is something worth pursuing, thanks. |
Hey, @barrymun. Thank you for taking the time to contribute to our project. I briefly talked about not adding code preview theme toggle to keep the simplicity in this issue #66. However, if community wants to see this feature being included, why not? Perhaps instead of highlighting just the code, we can update the theme of the whole website to match the code theme. I love to hear others' thoughts on this as well. |
@dostonnabotov Thanks for linking that issue. I've created a draft PR (which builds on #73 ) if you want to try out a sample version of what this could look like in its basic form. The suggestion whereby we update not only the style of the code but also the entire app could be a good one. Here is the related PR: #97. |
|
What feature would you like to see?
Import
PrismLight
instead ofPrism
when using thereact-syntax-highlighter
lib. Suggested here.This should improve performance and reduce the build size.
It is important to ensure that all functionality remains the same.
The text was updated successfully, but these errors were encountered: