Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with web form and ORCID ID field? #32

Open
astrofrog opened this issue Jun 23, 2016 · 4 comments
Open

Issue with web form and ORCID ID field? #32

astrofrog opened this issue Jun 23, 2016 · 4 comments

Comments

@astrofrog
Copy link
Contributor

astrofrog commented Jun 23, 2016

This auto-generated PR: https://github.com/dotastro/hack-list/pull/31 has an empty list item for ORCID - maybe the person submitted it put an empty space. We should strip whitespace from fields and make sure they aren't empty.

cc @dbouquin @eteq

@eteq
Copy link
Collaborator

eteq commented Jun 23, 2016

@astrofrog - should empty fields in the form yield non-existent yaml entries? I.e. no orcid entry instead of a blank value?

@astrofrog
Copy link
Contributor Author

I don't think it matters too much, as long as the syntax is valid

@eteq
Copy link
Collaborator

eteq commented Jun 23, 2016

@astrofrog - might the page-generator might make weird things of the entry is blank vs missing (@zemogle )?

@astrofrog
Copy link
Contributor Author

That's something we need to implement anyway on the generator side because manually submitted entries could have empty fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants