Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parameters case for chk generation #3

Open
kkalkhoff opened this issue Aug 19, 2019 · 0 comments
Open

Invalid parameters case for chk generation #3

kkalkhoff opened this issue Aug 19, 2019 · 0 comments

Comments

@kkalkhoff
Copy link

kkalkhoff commented Aug 19, 2019

Hey,

there is a bug in file Channel.php in public static function getCHK($inputParameters, $pin, array $subPayments = []) method which results in invalid chk value generated for request:

// Line 510 - 'URL' should be lowercase
(isset($inputParameters['URL']) ? $inputParameters['URL'] : null).
// Line 513 - 'URLC' should be lowercase
(isset($inputParameters['URLC']) ? $inputParameters['URLC'] : null).

where in official technical documentation those parameters are lowercase everywhere - https://www.dotpay.pl/developer/doc/api_payment/pl/index.html#ochrona-integralnosci-parametrow-przekierowania-chk

Or maybe it should be other way around and documentation should specify them as uppercase?
Either way it creates a divergence between those two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant