attachment images bugs

[bobbravo2]

Inside of the /models/attachment.php file, there is a lack of WordPress API usage - for instance using getimagesize & file_exists should probably not be used for performance, as WordPress stores that info in the attachment meta database.

Basically - the issue I'm having is very hard to debug based on the number of conditionals inside of JSON_API_Attachment::query_images()
Is the API not returning any images because the size php reports is different from what WordPress has stored? Is it because the webserver can't find the file path? Is the file path it's checking correct?

I'm left with a broken homepage because the API isn't returning any images, just an empty array.

[bobbravo2]

Apparently this issue has been fixed @master. Just cloned & checked out to try to fix the bug to make a pull request, and all of the changes I'd recommend were already done.