Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw4 review #6

Open
CanyonFoot opened this issue Feb 28, 2018 · 1 comment
Open

hw4 review #6

CanyonFoot opened this issue Feb 28, 2018 · 1 comment

Comments

@CanyonFoot
Copy link
Collaborator

@giocorti
@giocorti
Copy link

giocorti commented Mar 2, 2018

  1. I'm confused by the log price vs Dow Jones plots. Was this a part of HW4?

  2. Nice use of an API and nice nice lyric scrapping. Your code is also well documented which is helpful. Maybe nest time you should include a little more info about the API you used and where exactly to access it.

  3. The code for your plots looks neat, and the plots themselves are interesting. However I don't see any of the data import steps in the md file. After looking in the rmd I see where/how you got the data but you somehow suppressed this code chunk so it doesn't appear in the md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giocorti @CanyonFoot