Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit categories of older books for finer grain categorization #46

Open
duffn opened this issue Feb 22, 2020 · 4 comments
Open

Audit categories of older books for finer grain categorization #46

duffn opened this issue Feb 22, 2020 · 4 comments
Labels
data Pertaining to data creation or auditing enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@duffn
Copy link
Owner

duffn commented Feb 22, 2020

Right now all of the categories for attachments for example are very broad like Weapon, while they could be finer grained like Melee and Brawl Weapon Attachments, Grenade and Micro-Rocket Attachments, and Ranged Weapon Attachments.

We should go back and audit the older books to change the categories from the very broad definition to the tighter definition.

@duffn duffn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers data Pertaining to data creation or auditing labels Feb 22, 2020
@bknowles
Copy link

Where are the tighter definitions ... well ... defined? Are they in a YAML file in this repo?

Because I've just spent hours typing in various weapons from Gadgets and Gear, and I'm not exactly happy that Lightsabers are classified as "Melee Weapons" that use the Lightsaber skill, among other things. I'd rather classify these as Lightsaber Weapons, using the Lightsaber skill.

But maybe that's just me.

@duffn
Copy link
Owner Author

duffn commented Feb 27, 2020

They are nowhere at the moment and need to be defined. But we can certainly reclassify anything anyway that we see fit. I’m open to suggestions, especially from the more experienced SWRPG players like yourself.

@bknowles
Copy link

Let me get through G&G and then we can see how things fall out.
I don’t want to make any proclamations yet based on incomplete information.

@duffn
Copy link
Owner Author

duffn commented Feb 28, 2020

Sounds good. There’s some interesting data, as you’ve found yourself, coming from the books that we’ll need to figure out how to handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Pertaining to data creation or auditing enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants