Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoustomerGauge - document the unpack_* parameters #1056

Open
gwieloch opened this issue Sep 25, 2024 · 2 comments
Open

CoustomerGauge - document the unpack_* parameters #1056

gwieloch opened this issue Sep 25, 2024 · 2 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request

Comments

@gwieloch
Copy link
Contributor

gwieloch commented Sep 25, 2024 •
edited by trymzet
Loading

Trymzet: What are this params for? I didn't get this neither from this docstring nor from the unpacking function. I mean I know what it does, but why is it needed in the first place? Can you maybe provide an example of usage?

possibly param can be skipped in the final flow and defined within the task

#1040 (comment)
@gwieloch gwieloch added enhancement New feature or request question Further information is requested labels Sep 25, 2024
@gwieloch gwieloch mentioned this issue Sep 25, 2024
Merged
5 tasks
@gwieloch gwieloch added 2.0 backlog Backlog for logic issues in connectors after migration and removed question Further information is requested labels Sep 26, 2024
@gwieloch
Copy link
Contributor Author

linked PR - https://github.com/dyvenia/viadot/pull/1040/files

@trymzet
Copy link
Contributor

trymzet commented Sep 26, 2024

@gwieloch FYI you can link the comment directly like this
image

@trymzet trymzet changed the title unpack_by_nested_dict_transformer in customer_gauge CoustomerGauge - document the unpack_by_nested_dict_transformer parameter Sep 27, 2024
@trymzet trymzet changed the title CoustomerGauge - document the unpack_by_nested_dict_transformer parameter CoustomerGauge - document the unpack_* parameters Sep 27, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @gwieloch