Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With "Open Side By Side" enabled, split panes are continually added #23

Open
forivall opened this issue Mar 12, 2020 · 1 comment · May be fixed by #44
Open

With "Open Side By Side" enabled, split panes are continually added #23

forivall opened this issue Mar 12, 2020 · 1 comment · May be fixed by #44

Comments

@forivall
Copy link

forivall commented Mar 12, 2020

Issue Type: Bug

Steps to Reproduce:

  1. Find related -> open file
  2. Do it again on the new file, selecting what was the original file
  3. Expected: it should focus on the original file, instead, it opens a new split pane to the right.

Also, it takes a reload for changes to the "Open Side By Side" option to take effect, which is more of an annoying quirk.

Extension version: 0.9.0
VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:34:44.548Z)
OS version: Darwin x64 18.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3470S CPU @ 2.90GHz (4 x 2900)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (1.17GB free)
Process Argv
Screen Reader no
VM 0%
Settings
  "findrelated.rulesets": [
    {
      "name": "js",
      "rules": [
        {
          "pattern": "(.+)\/([^\/]+?)\\.([tj]sx?)$",
          "locators": [
            "$1/{test,tests,__tests__,__test__}/$2{.spec,.test,}.$3"
          ]
        },
        {
          "pattern": "src/(.+)\/([^\/]+?)\\.([tj]sx?)$",
          "locators": [
            "src/$1/{test,tests,__tests__,__test__}/$2{.spec,.test,}.$3",
            "{test,tests,__tests__,__test__}/$1/$2{.spec,.test,}.$3",
          ]
        },
        {
          "pattern": "(.+)\/(?:tests?|__tests?__)\/((?:.+?/)?(?:[^\/]+?))(?:\\.spec|\\.test)?\\.([tj]sx?)$",
          "locators": [
            "$1/$2.$3",
            "src/$1/$2.$3"
          ]
        },
        {
          "pattern": "(?:tests?|__tests?__)\/((?:.+?/)?(?:[^\/]+?))(?:\\.spec|\\.test)?\\.([tj]sx?)$",
          "locators": [
            "$1.$2",
            "src/$1.$2"
          ]
        }
      ]
    }
  ],
  "findrelated.applyRulesets": [
    "aspnet",
    "aspnet-mvc",
    "aurelia",
    "c/c++",
    "csharp",
    "minified",
    "xaml",
    "js"
  ],
  "findrelated.openSideBySide": true,
forivall added a commit to forivall/vscode-find-related that referenced this issue Jun 1, 2022
@Gregory108
Copy link

And even further: adding "workbench.editor.revealIfOpen": true, does not solve the problem

@Gregory108 Gregory108 linked a pull request Jun 15, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants