Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to the VS Code marketplace #119

Closed
thegecko opened this issue Feb 19, 2024 · 11 comments
Closed

Publish to the VS Code marketplace #119

thegecko opened this issue Feb 19, 2024 · 11 comments

Comments

@thegecko
Copy link

This doesn't seem to have been published to the main VS Code marketplace, any reason why it shouldn't be?

@spoenemann
Copy link

See also #40

@jreineckearm
Copy link
Contributor

@jonahgraham , there is some interest on our side to get this published to the VS Code marketplace as a CDT Cloud extension.
And to update the README with user focused contents. Like explaining the possible launch configuration items.

We would be happy to pick this up. Any objections or thoughts on this?

@jonahgraham
Copy link
Contributor

No objection - quite the opposite.

As mentioned in the last cdt cloud call, the build infra here is quite sorely out of date, this is what I summarized at the call, but I don't know when I will have time to do this:

This highlighted that the extension (cdt-gdb-vscode) is quite dated in technology and has failed to publish recently. I (Jonah) am considering doing a whole-scale update, which will mean another major version bump to highlight that change.

@thegecko
Copy link
Author

thegecko commented Jan 8, 2025

I'm hoping it should be quite easy to copy the CI from one of our other extensions.

@jreineckearm
Copy link
Contributor

Great, thanks, @jonahgraham and @thegecko !

I'm hoping it should be quite easy to copy the CI from one of our other extensions.

Yes, my intention is to start from existing extensions like the "Inspector" extensions. Unless you have something else in mind. We can then discuss on the PR if this is sufficient or should be further refined/provide more functionality.

I might just need some assistance with setting up secrets as I certainly don't have the required rights to do so myself.

Also happy to have a look at dependencies (I see dependabot was busy here already). But probably as a separate PR. And would need some support from others to test their use cases.

@jonahgraham
Copy link
Contributor

Yes, my intention is to start from existing extensions like the "Inspector" extensions. Unless you have something else in mind. We can then discuss on the PR if this is sufficient or should be further refined/provide more functionality.

Sounds good to me. I have nothing else in mind.

I might just need some assistance with setting up secrets as I certainly don't have the required rights to do so myself.

I am hoping @thegecko can handle this part, but lmk if you need me for any of it.

@thegecko
Copy link
Author

thegecko commented Jan 8, 2025

We have org wide secrets set up for publishing all extensions, copying another CI workflow should 'just work'.

@jreineckearm
Copy link
Contributor

We have org wide secrets set up for publishing all extensions, copying another CI workflow should 'just work'.

Nice!

@thegecko
Copy link
Author

Should be closed in #130

@jreineckearm
Copy link
Contributor

The good news is that the CI Github action started kicking after merging #130 . So, we can test this now properly on branches.
The bad news is that the latest vsce version doesn't like node 14 but requires version 20. I'll see how far I get with bumping the node version. If things fall apart with that node update we need to worst case roll back to https://github.com/microsoft/vscode-vsce/releases/tag/v2.15.0 which is the last version with node 14 support.

@jreineckearm
Copy link
Contributor

Should be fixed with node 20 update in #131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants